use AggregationStorePermissionExecutor for Aggregation Store Model #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,7 +100,7 @@ public AggregationStorePermissionExecutor(RequestScope requestScope) { | |||
| ChangeSpec changeSpec, | |||
| Class<A> annotationClass, | |||
| String field) { | |||
| throw new UnsupportedOperationException(); | |||
| return checkSpecificFieldPermissions(resource, changeSpec, annotationClass, field); | |||
There was a problem hiding this comment.
This method is called a bunch of times. Since we only have user check on fields, I guess it would make sense to do what checkSpecificFieldPermissions in here.
aklish
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use AggregationStorePermissionExecutor for Aggregation Store Model.
Fix bugs on AggregationStorePermissionExecutor
How Has This Been Tested?
IT
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.